metrics-server icon indicating copy to clipboard operation
metrics-server copied to clipboard

Support for certManager in helmChart and CLI

Open pragmaticivan opened this issue 2 years ago • 2 comments

What would you like to be added: I would like to add a new property such as:

certificates:
  certManager:
    enabled: true

ref

Parameter Type Default Description
certificates.certManager.caSecretName string "metrics-server-ca" Secret name where the CA is stored (generatedby cert-manager or user given)
certificates.certManager.enabled bool false Enables Cert-manager for certificate management
certificates.certManager.generateCA bool true Generates a self-signed CA with Cert-manager. If generateCA is false, the secret with the CA has to be annotated with cert-manager.io/allow-direct-injection: "true"
certificates.certManager.secretTemplate object {} Add labels/annotations to secrets created by Certificate resources docs
certificates.mountPath string "/certs" Path where metrics-server TLS certificates are mounted
certificates.secretName string "metrics-server-certs" Secret name to be mounted with metrics-server TLS certificates

This would integrate metrics-server with certManager automatically instead of providing caBundle manually.

KEDA templates for ref: https://github.com/kedacore/charts/tree/main/keda/templates/cert-manager

Why is this needed: To improve setup and operation.

/kind feature

pragmaticivan avatar Sep 07 '23 20:09 pragmaticivan

/assign @stevehipwell /triage accepted

dashpole avatar Sep 21 '23 16:09 dashpole

#1288 should cover this.

stevehipwell avatar Sep 21 '23 17:09 stevehipwell