mcs-api
mcs-api copied to clipboard
kubernetes-sigs
Update service controller to add all the IPs from derived service
Update the Service controller to update the ServiceImport with all the IPs instead of only the first IP.
A bit related to #63 might not be the complete answer for this though
It's been a while that we are discussing v1alpha2 but not going forward with it. And this is a non breaking change so I would like to do this change + the related api change to v1alpha1 here instead of waiting for v1alpha2 if that's ok for you.
cc @tpantelis @mikemorris @skitt :pray:
Sorry I've been behind following up on your work! This feels okay to me, may need to regenerate the CRD YAML in this PR now though.
Sorry I've been behind following up on your work! This feels okay to me, may need to regenerate the CRD YAML in this PR now though.
No worries, actually I have already regenerated the yaml so it should be fine on that aspect :+1:
Hmm I can't reproduce the CI failure locally let's try a bit more :sweat_smile: /test pull-mcs-api-e2e
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mikemorris, MrFreezeex, skitt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [skitt]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
