mcs-api icon indicating copy to clipboard operation
mcs-api copied to clipboard

implement test 2: local service not impacted

Open nojnhuh opened this issue 1 year ago • 2 comments

This PR adds tests to ensure unexported services still behave as expected in the presence of exported ones as described in #16.

Closes #16

nojnhuh avatar Jun 25 '24 02:06 nojnhuh

@skitt could you kindly give this a review?

jackfrancis avatar Jul 09 '24 00:07 jackfrancis

/hold for squash (if that's desired)

nojnhuh avatar Jul 26 '24 16:07 nojnhuh

Thanks! Do please squash these, without even waiting for other reviews — I think the overall result is now easier to review than the individual commits. While you’re at it, if you don’t mind, there are a few stout typos instead of stdout :wink:.

skitt avatar Jul 29 '24 16:07 skitt

/lgtm

skitt avatar Jul 30 '24 07:07 skitt

/assign @JeremyOT

skitt avatar Jul 30 '24 07:07 skitt

/hold cancel /approve

skitt avatar Aug 01 '24 07:08 skitt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 01 '24 07:08 k8s-ci-robot