kubernetes-sigs
remove discoveryv1beta1 from e2e tests
Non-ancient versions of Kubernetes (1.22-ish? and later) do not serve v1beta1 of the discovery APIs which include EndpointSlices. This PR removes logic dealing with that API version, which was only present in the connectivity e2e test.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nojnhuh Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@skitt can we merge this?
Yes, and I’ll be able to take care of it once #56 is merged :wink:.
I think https://github.com/kubernetes-sigs/mcs-api/pull/53 supercedes this, not sure this is needed. Let's wait for @nojnhuh to return from vacation and he can close this out, if true.
@nojnhuh literally commented as such here: https://github.com/kubernetes-sigs/mcs-api/pull/53#discussion_r1693356186 :)
Whomever has perms can close this PR, it's no longer relevant.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@nojnhuh: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.