clean: remove unused hello serviceExport defs

[Xunzhuo]

helloServiceExport is not used in anywhere

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xunzhuo Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[lauralorenz]

/remove-lifecycle rotten

[mikemorris]

I think this should probably be used at https://github.com/kubernetes-sigs/mcs-api/blob/2833f83cfbdc46d80e0e18111ec977c4ef16e51d/conformance/connectivity_test.go#L92-L93 instead of creating a new ServiceExport inline there.

[tpantelis]

I think this should probably be used at

https://github.com/kubernetes-sigs/mcs-api/blob/2833f83cfbdc46d80e0e18111ec977c4ef16e51d/conformance/connectivity_test.go#L92-L93

instead of creating a new ServiceExport inline there.

I think statically defining the resource objects is fine for the two simple tests we have now. But as we expand the tests, we'll likely want to create more than one service and headless services and maybe alter the service spec. So I think defining them globally/statically becomes less useful and maybe cumbersome. I think it's more useful to have functions to create them, eg createServiceExport(name string) (which I've added locally in a pending commit).

[tpantelis]

This PR can be closed in favor of https://github.com/kubernetes-sigs/mcs-api/pull/60 which is a duplicate but it is newer and active.

[skitt]

Thanks @Xunzhuo for your contribution; I’ve merged #60 which is more comprehensive.

/close

[k8s-ci-robot]

@skitt: Closed this PR.

In response to this:

Thanks @Xunzhuo for your contribution; I’ve merged #60 which is more comprehensive.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.