mcs-api icon indicating copy to clipboard operation
mcs-api copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

chore: go mod tidy

Open Xunzhuo opened this issue 1 year ago • 6 comments

chore: go mod tidy

it made failures in make demo:

o run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile=./hack/boilerplate.go.txt paths="./..."
../../go/pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/exec.go:36:2: missing go.sum entry for module providing package golang.org/x/term (imported by k8s.io/client-go/plugin/pkg/client/auth/exec); to add:
        go get k8s.io/client-go/plugin/pkg/client/auth/[email protected]
Error: not all generators ran successfully
run `controller-gen object:headerFile=./hack/boilerplate.go.txt paths=./... -w` to see all available markers, or `controller-gen object:headerFile=./hack/boilerplate.go.txt paths=./... -h` for usage
exit status 1
make: *** [generate] Error 1

Xunzhuo avatar Dec 11 '23 06:12 Xunzhuo

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xunzhuo Once this PR has been reviewed and has the lgtm label, please assign lauralorenz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 11 '23 06:12 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 10 '24 08:03 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 09 '24 08:04 k8s-triage-robot

/remove-lifecycle rotten

lauralorenz avatar May 01 '24 19:05 lauralorenz

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 30 '24 11:05 k8s-ci-robot

I think this is outdated and should be resolved as of https://github.com/kubernetes-sigs/mcs-api/pull/49 merging, suggest closing.

mikemorris avatar May 31 '24 20:05 mikemorris

This is indeed obsolete.

/close

skitt avatar Aug 05 '24 10:08 skitt

@skitt: Closed this PR.

In response to this:

This is indeed obsolete.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 05 '24 10:08 k8s-ci-robot