mcs-api
mcs-api copied to clipboard
kubernetes-sigs
Update e2e tests to support k8s 1.21+ only, particularly to fix EndpointSlice version errors when using them today
We happen to be observing a breakage in our e2e tests against clusters running above Kubernetes version 1.21. This is because the MCS API is dependent on EndpointSlices and the e2e tests happened to have been written when EndpointSlice was in v1beta1 and implemented as such, but which GA'd to v1 in Kubernetes 1.21.
Per discussion in SIG-MC today 11/15/2022, e2etests have a lower standard of backwards compatibility than vendor implementations might choose, and we are ok with making them work against only the GA version of EndpointSlice, even in their role as conformance tests. Some of the reasons given were because it's been out for longer than a year, that in the purview of MCS API history its been a stable dependency, etc.
@lauralorenz: This request has been marked as needing help from a contributor.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
/help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Can confirm this is fixed by #24, just need to remove the pin on 1.21 in the cluster setup (ie https://github.com/kubernetes-sigs/mcs-api/blob/master/scripts/c1.yaml#L10)
