kwok icon indicating copy to clipboard operation
kwok copied to clipboard

Support sync node status.images with pod

Open wzshiming opened this issue 1 year ago • 14 comments

What would you like to be added?

  • Support sync node status.images with pod
  • Add a flag to allow kwok-controller to enable this feature.

Why is this needed?

Refinement of simulated kubelet behavior

wzshiming avatar Nov 15 '23 11:11 wzshiming

Hi, I'm interested to contribute to this feature.

Do you have any pointers on where to start? Thank you.

kevinmingtarja avatar Dec 24 '23 07:12 kevinmingtarja

My idea would be to add a template function to node template that would look like this

images:
{{ with NodeImages status.images }}
{{ YAML . 1 }}
{{ end }}

The NodeImages return will contain the status.images and the images used by the pods on this node.

wzshiming avatar Dec 25 '23 02:12 wzshiming

Hi, @wzshiming. Is the feature independent of v1alpha2?

caozhuozi avatar Jan 26 '24 08:01 caozhuozi

Hi, @wzshiming. Is the feature independent of v1alpha2?

Yes, It add a template function to the Node Controller

wzshiming avatar Jan 26 '24 08:01 wzshiming

/assign

caozhuozi avatar Jan 26 '24 08:01 caozhuozi

https://github.com/kubernetes-sigs/kwok/issues/977#issuecomment-1951162145

I plan to add a new API that should cover this capability

wzshiming avatar Feb 18 '24 11:02 wzshiming

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 18 '24 11:05 k8s-triage-robot

/assign

Manoramsharma avatar May 19 '24 15:05 Manoramsharma

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 27 '24 13:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jul 27 '24 13:07 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 27 '24 13:07 k8s-ci-robot

/remove-lifecycle rotten /reopen

wzshiming avatar Jul 29 '24 05:07 wzshiming

@wzshiming: Reopened this issue.

In response to this:

/remove-lifecycle rotten /reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 29 '24 05:07 k8s-ci-robot