kwok icon indicating copy to clipboard operation
kwok copied to clipboard

Fix logger fmt

Open sivchari opened this issue 3 years ago • 7 comments

I fixed logger format.

sivchari avatar Aug 10 '22 16:08 sivchari

Hi @sivchari. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 10 '22 16:08 k8s-ci-robot

Welcome @sivchari!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 10 '22 16:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sivchari Once this PR has been reviewed and has the lgtm label, please assign huang-wei for approval by writing /assign @huang-wei in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 10 '22 16:08 k8s-ci-robot

/kind bug

sivchari avatar Aug 10 '22 16:08 sivchari

/assign @wzshiming

sivchari avatar Aug 31 '22 14:08 sivchari

/ok-to-test

wzshiming avatar Aug 31 '22 16:08 wzshiming

@sivchari: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kwok-e2e-test-main 10ba893f34d0c640f8420138fe64e5808d281b0a link true /test pull-kwok-e2e-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Aug 31 '22 18:08 k8s-ci-robot

@sivchari: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 09 '22 18:11 k8s-ci-robot

The logger library has been updated now, so let me close this. Thank you. /close

wzshiming avatar Nov 30 '22 03:11 wzshiming

@wzshiming: Closed this PR.

In response to this:

The logger library has been updated now, so let me close this. Thank you. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 30 '22 03:11 k8s-ci-robot