Migration for dryrun tests to e2e
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR migrates the rest of the shell dryrun tests to e2e.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @NeerajNagure. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for k8s-kwok canceled.
| Name | Link |
|---|---|
| Latest commit | 3e366970ee0d5b25e3dff08276cd75d21ad87f9e |
| Latest deploy log | https://app.netlify.com/sites/k8s-kwok/deploys/668e9f879f8eef00083bb90d |
Deploy Preview for k8s-kwok ready!
| Name | Link |
|---|---|
| Latest commit | 80a6e5d9c0b388db633edfa88ec8cf8e12d92544 |
| Latest deploy log | https://app.netlify.com/sites/k8s-kwok/deploys/669e0d470584730008b2a275 |
| Deploy Preview | https://deploy-preview-1173--k8s-kwok.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@wzshiming i have made all the required changes and also updated the testdata
/ok-to-test
=== RUN TestLogs/Pod_Logs/test_dryrun_export_logs
logs.go:58: Expected vs got:
strings.Join({
"mkdir -p <ROOT_DIR>/workdir/clusters/<CLUSTER_NAME>/export/logs",
+ "\r",
"\ncp <ROOT_DIR>/workdir/clusters/<CLUSTER_NAME>/kwok.yaml <ROOT_D",
"IR>/workdir/clusters/<CLUSTER_NAME>/export/logs/kwok.yaml",
+ "\r",
"\nmkdir -p <ROOT_DIR>/workdir/clusters/<CLUSTER_NAME>/export/logs",
"/components",
+ "\r",
https://github.com/kubernetes-sigs/kwok/actions/runs/9927554120/job/27422653794?pr=1173
=== RUN TestRestart/Restart/test_start_dryrun
error: lost connection to pod
restart.go:76: Expected vs got:
strings.Join({
"cd <ROOT_DIR>/workdir/clusters/<CLUSTER_NAME> &&",
- " ETCD_UNSUPPORTED_ARCH=<ARCH>",
" etcd --name=node0 --auto-compaction-retention=1 --quota-backend",
"-bytes=8589934592 --data-dir=<ROOT_DIR>/workdir/clusters/<CLUSTE",
... // 3863 identical bytes
}, "")
https://github.com/kubernetes-sigs/kwok/actions/runs/9927554120/job/27422654173?pr=1173
There are 2 failed tests from this change
@wzshiming I have fixed the issue and now those dryrun tests only run on linux
/retest
@wzshiming can you please review this PR?
@wzshiming I have implemented the change suggested by you.Please take a look.
@wzshiming I have squashed all the commits
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: NeerajNagure, wzshiming
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [wzshiming]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment