kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard
verified publisher icon kubernetes-sigs

fix: remove deprecated `commonLabels`

Open chansuke opened this issue 4 months ago • 8 comments

Closes #5653

replace deprecated commonLabels with labels

the following files were intentionally unchanged:

  • examples/transformerconfigs/README.md // the documentation of transformer
  • site/content/ // API reference document
  • examples/alphaTestExamples/helloapp.md // alpha test example
  • examples/zh/ // Chinese translation (out of scope)
  • test files that needed for backwards compatibility testing

chansuke avatar Aug 19 '25 09:08 chansuke

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Aug 19 '25 09:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chansuke Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 19 '25 09:08 k8s-ci-robot

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 19 '25 09:08 k8s-ci-robot

/lgtm

sarab97 avatar Aug 19 '25 16:08 sarab97

@sarab97: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 19 '25 16:08 k8s-ci-robot

Hi @chansuke

Thanks for your help! I added one comment, please check that.

By the way, I think we're still using deprecated fields in our official docs. Could you fix those too? https://github.com/kubernetes-sigs/cli-experimental/tree/master/site

koba1t avatar Aug 21 '25 04:08 koba1t

@koba1t Thank you so much for your review!! Yes, I will handle this too:)

chansuke avatar Aug 22 '25 08:08 chansuke

/uncc

stormqueen1990 avatar Sep 14 '25 21:09 stormqueen1990

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 19 '25 15:12 k8s-triage-robot