kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

Bumping to kustomize/kyaml v0.18.0 breaks kustomize/api v0.17.3 and kustomize/cmd/config v0.14.2

Open kashifest opened this issue 1 year ago • 3 comments

What happened?

Dependabot picked up the kustomize/kyaml v0.18.0 tag and pushed a bump PR. Now after the bump the build fails with the following issues

# sigs.k8s.io/kustomize/api/internal/plugins/fnplugin
/Users/kashif/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/internal/plugins/fnplugin/fnplugin.go:80:4: unknown field EnableStarlark in struct literal of type runfn.RunFns
# sigs.k8s.io/kustomize/cmd/config/internal/commands
/Users/kashif/go/pkg/mod/sigs.k8s.io/kustomize/cmd/[email protected]/internal/commands/run-fns.go:349:3: unknown field EnableStarlark in struct literal of type runfn.RunFns
make: *** [tools/bin/kustomize] Error 1

This possibly comes from the fact that it was removed here https://github.com/kubernetes-sigs/kustomize/commit/d32eacf034dec905a61423b7039feb44bdb2d3b5#diff-552ed910d0395b5defc5b44042a559e4795558e8d82cd9858199a6f1191746bf and this commit exists in kustomize/kyaml v0.18.0 tag. Do we need corresponding tags/releases for kustomize/api and /kustomize/cmd/config ?

What did you expect to happen?

build should work fine after the bump

How can we reproduce it (as minimally and precisely as possible)?

Just bump to kustomize/kyaml v0.18.0 and if you also have dependancy on kustomize/api or kustomize/cmd/config you should hit this.

Expected output

No response

Actual output

No response

Kustomize version

5.4.3

Operating system

None

kashifest avatar Oct 08 '24 06:10 kashifest

Hi @kashifest

So sorry to made broken release. I was fixed with create new releases with below lists. Could you try to use below versions? 'kyaml/v0.18.1', 'api/v0.18.0' and 'cmd/config/v0.15.0'

koba1t avatar Oct 17 '24 03:10 koba1t

/triage accepted

koba1t avatar Oct 17 '24 04:10 koba1t

Hi @koba1t thanks for the new release tags, things are working now it seems

kashifest avatar Oct 24 '24 09:10 kashifest

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Oct 24 '25 09:10 k8s-triage-robot

Hi @koba1t thanks for the new release tags, things are working now it seems

I think we have fixed, this. /close

tuminoid avatar Oct 24 '25 11:10 tuminoid

@tuminoid: Closing this issue.

In response to this:

Hi @koba1t thanks for the new release tags, things are working now it seems

I think we have fixed, this. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 24 '25 12:10 k8s-ci-robot