kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

fix:kustomize cfg grep with no arguments causes panic

Open deszhou opened this issue 1 year ago • 5 comments

  • Before the Fix
➜  ✗ kustomize cfg grep                                
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
sigs.k8s.io/kustomize/cmd/config/internal/commands.(*GrepRunner).preRunE(0x104cf5ad0?, 0x0?, {0x105ac5f68?, 0x104cf0f8c?, 0x1400018bd00?})
          /Users/denniszh/kustomize/cmd/config/internal/commands/grep.go:69 +0x3bc
github.com/spf13/cobra.(*Command).execute(0x14000287b08, {0x105ac5f68, 0x0, 0x0})
        /Users/denniszh/go/pkg/mod/github.com/spf13/[email protected]/command.go:968 +0x7e8
github.com/spf13/cobra.(*Command).ExecuteC(0x140001e2608)
         /Users/denniszh/go/pkg/mod/github.com/spf13/[email protected]/command.go:1115 +0x344
github.com/spf13/cobra.(*Command).Execute(0x1059bbfa8?)
        /Users/denniszh/go/pkg/mod/github.com/spf13/[email protected]/command.go:1039 +0x1c
main.main()
       /Users/denniszh/kustomize/kustomize/main.go:14 +0x20
  • After the Fix
➜ ✗ kustomize cfg grep
Error: missing required argument: QUERY
Usage:
 kustomize cfg grep QUERY [DIR] [flags]

Examples:

   # find Deployment Resources
   kustomize cfg grep "kind=Deployment" my-dir/

   # find Resources named nginx
   kustomize cfg grep "metadata.name=nginx" my-dir/

   # use tree to display matching Resources
   kustomize cfg grep "metadata.name=nginx" my-dir/ | kustomize cfg tree

   # look for Resources matching a specific container image
   kustomize cfg grep "spec.template.spec.containers[name=nginx].image=nginx:1\.7\.9" my-dir/ | kustomize cfg tree

Flags:
     --annotate              annotate resources with their file origins. (default true)
 -h, --help                  help for grep
     --invert-match          Selected Resources are those not matching any of the specified patterns..
 -R, --recurse-subpackages   also print resources recursively in all the nested subpackages (default true)

Global Flags:
     --stack-trace   print a stack-trace on error

Fixes: #5701

deszhou avatar May 28 '24 03:05 deszhou

Welcome @yeedove!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar May 28 '24 03:05 k8s-ci-robot

Hi @yeedove. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 28 '24 03:05 k8s-ci-robot

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 29 '24 02:05 k8s-ci-robot

/ok-to-test /label tide/merge-method-squash

stormqueen1990 avatar Jun 05 '24 03:06 stormqueen1990

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deszhou, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 10 '24 07:07 k8s-ci-robot