kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

Fix: Replace deprecated commonLabels with labels in examples directory.

Open ah8ad3 opened this issue 1 year ago • 15 comments

Related to https://github.com/kubernetes-sigs/kustomize/issues/5653. Replace commonLables inside example directory with lables to avoid deprecated message.

ah8ad3 avatar Apr 15 '24 12:04 ah8ad3

Hi @ah8ad3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 15 '24 12:04 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ah8ad3 Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 15 '24 12:04 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 14 '24 13:07 k8s-triage-robot

/remove-lifecycle rotten /cc

stormqueen1990 avatar Aug 12 '24 20:08 stormqueen1990

/retest

ah8ad3 avatar Aug 13 '24 05:08 ah8ad3

@ah8ad3: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 13 '24 05:08 k8s-ci-robot

/remove-lifecycle stale

stormqueen1990 avatar Sep 03 '24 19:09 stormqueen1990

/kind documentation

stormqueen1990 avatar Sep 03 '24 19:09 stormqueen1990

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ah8ad3 Once this PR has been reviewed and has the lgtm label, please ask for approval from koba1t. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 03 '24 20:09 k8s-ci-robot

/retest

koba1t avatar Sep 03 '24 20:09 koba1t

@ah8ad3 Could you try rebase master?

koba1t avatar Sep 03 '24 20:09 koba1t

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Sep 04 '24 15:09 k8s-ci-robot

Could you try rebase master?

Done, PTAL

ah8ad3 avatar Sep 04 '24 15:09 ah8ad3

/retest

koba1t avatar Sep 10 '24 16:09 koba1t

@ah8ad3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kustomize-presubmit-master 7f420a6351b159adf040fe6babcfe50cb35061b4 link true /test kustomize-presubmit-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Sep 10 '24 17:09 k8s-ci-robot

Hi @ah8ad3 Can you investigate why that test is still failed?

koba1t avatar Sep 10 '24 17:09 koba1t