kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

kustomize example in README uses deprecated commonLabels

Open paololazzari opened this issue 1 year ago • 5 comments

What happened?

When running the example in the README:

# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Kustomize version

v5.4.1

paololazzari avatar Apr 10 '24 11:04 paololazzari

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 10 '24 11:04 k8s-ci-robot

@paololazzari Thanks for brining up this issue. The docs do seem to be outdated: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/.

Would you be open to submitting a PR to fix this in the docs website. Any help from the community is appreciated. Thanks!

varshaprasad96 avatar Apr 10 '24 16:04 varshaprasad96

cc: @ncapps

varshaprasad96 avatar Apr 10 '24 16:04 varshaprasad96

Maybe i can help with this issue.

ah8ad3 avatar Apr 11 '24 09:04 ah8ad3

The docs do seem to be outdated: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/.

@varshaprasad96 The actual version of Kustomize inside kubectl is old i don't think we should update this until the version is bumped up. Instead i think we should update this site, https://kubectl.docs.kubernetes.io/references/kustomize/ Also the examples.

ah8ad3 avatar Apr 15 '24 11:04 ah8ad3