kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

Add static value source for replacement

Open cunyat opened this issue 1 year ago • 9 comments

Introduces sourceValue key on replacement for replacing from a static value instead of sourcing from another object.

Solves #5516

cunyat avatar Mar 28 '24 19:03 cunyat

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cunyat Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 28 '24 19:03 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: cunyat / name: Ramon Cuñat (6c27970019456dc0cfe4928e3ac03e0fd6ff2415)

Welcome @cunyat!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 28 '24 19:03 k8s-ci-robot

Hi @cunyat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 28 '24 19:03 k8s-ci-robot

/ok-to-test

varshaprasad96 avatar Jun 12 '24 17:06 varshaprasad96

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 12 '24 21:06 k8s-ci-robot

@cnmcavoy Thanks for the PR! Just one nit, which would be nice to fix.

Also, looks like the linter is failing. It's not related to changes in this PR, but if we merge it without getting all the tests green then we would end up failing all the PRs. Could you please all fix it.

I've removed the commit fixing that test as it is already fixed in upstream

cunyat avatar Jul 25 '24 12:07 cunyat

HI @varshaprasad96 Can you recheck this PR?

koba1t avatar Sep 12 '24 22:09 koba1t

I deleted my previous comment (asking when this will be merged) upon further reflection. See https://github.com/kubernetes-sigs/kustomize/issues/5063#issuecomment-2348372336 for the rationale.

ErwanDL avatar Sep 13 '24 08:09 ErwanDL