kubernetes-sigs
[WIP] feat: support labels key in transformer configuration
Allow the usage of a separate transformer configuration for the labels key, similar to what is currently available for commonLabels and commonAnnotations. This aims to provide the same functionality that commonLabels currently provide for labels, since commonLabels is deprecated and slated for removal in a future release.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @stormqueen1990 I think this PR looks good! I added a few minor comments. Could you check those and fix the conflict?
Hi @stormqueen1990 I think this PR looks good! I added a few minor comments. Could you check those and fix the conflict?
Done! Let me know if there's anything else that needs to be addressed 😄
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: koba1t, stormqueen1990
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [koba1t]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment