kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

Introduce support for Catalogs that enable specifying KRMFunctions

Open varshaprasad96 opened this issue 1 year ago • 6 comments
trafficstars

This PR adds support to Kustomize Function catalogs as mentioned in the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/2906-kustomize-function-catalog.

This change introduces an option for users to specify path to their catalog configuration file in kustomization.yaml. It introduces logic to fetch the function spec from an individual catalog whose spec contains a GVK matches the resource or from the annotation. This feature is currently supported only in Transformers.

Follow up:

  • Introduce catalog support in generators.
  • Update documentation on this feature.
  • Enable specifying trusted catalogs.

varshaprasad96 avatar Jan 05 '24 20:01 varshaprasad96

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 05 '24 20:01 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 26 '24 15:01 k8s-ci-robot

Apologies for a bunch of lint fixes in this PR to make the linter happy.

The tests which had been failing initially on the PR having been passing locally. The recent push should re-trigger the tests to ensure that it is not a flake.

varshaprasad96 avatar Jan 26 '24 15:01 varshaprasad96

/cc

stormqueen1990 avatar Jan 31 '24 22:01 stormqueen1990

Apologies for a bunch of lint fixes in this PR to make the linter happy.

The tests which had been failing initially on the PR having been passing locally. The recent push should re-trigger the tests to ensure that it is not a flake.

How do you feel about splitting the formatting changes that happened in files unrelated to this implementation into a new PR?

stormqueen1990 avatar Feb 05 '24 03:02 stormqueen1990

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 07 '24 06:03 k8s-ci-robot