kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

Add an option in kustomize lib to suppress the deprecation warnings

Open davidbaena opened this issue 1 year ago • 15 comments

The goal of this PR is to add and Logger option to suppress warnings if user integrates kustomize in his project. But the kustomize binary still printing warnings by default.

Implementation I injected a slog.Logger in KustTarget this way the lib user might pass a custom logger.

In order to configure this logger, I extended de Options to add a new field called LogLevel which is filled by default as Info (just to be compatible with the current binary version)

Fixes: https://github.com/kubernetes-sigs/kustomize/issues/5452

./go/bin/kustomize build kustomization-foo
{"time":"2023-11-29T21:26:25.85695+01:00","level":"WARN","msg":"# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically."}
...

davidbaena avatar Nov 28 '23 21:11 davidbaena

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 28 '23 21:11 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidbaena Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 28 '23 21:11 k8s-ci-robot

Welcome @davidbaena!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Nov 28 '23 21:11 k8s-ci-robot

Hi @davidbaena. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 28 '23 21:11 k8s-ci-robot

Hello @natasha41575 could you help me with the review process?

davidbaena avatar Nov 29 '23 20:11 davidbaena

/ok-to-test

natasha41575 avatar Nov 30 '23 16:11 natasha41575

/retest

davidbaena avatar Nov 30 '23 20:11 davidbaena

/retest-required

davidbaena avatar Nov 30 '23 21:11 davidbaena

/test all

davidbaena avatar Nov 30 '23 22:11 davidbaena

/test MacOS

davidbaena avatar Dec 02 '23 16:12 davidbaena

@davidbaena: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test kustomize-presubmit-master

Use /test all to run all jobs.

In response to this:

/test MacOS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 02 '23 16:12 k8s-ci-robot

Hello @yuwenma, @annasong20, do you mind to review this PR 🙏 If you need some extra description do not hesitate to ask me 💪

davidbaena avatar Dec 11 '23 09:12 davidbaena

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 10 '24 10:03 k8s-triage-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 27 '24 18:03 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 26 '24 19:04 k8s-triage-robot