kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

Sort built-in Namespace kind before CRDs with the same name

Open danielwilsonkainos opened this issue 2 years ago • 12 comments

Adds differentiation and correct priority between ASO ServiceBus Namespace kind and core Kubernetes Namespace kind when sorting kustomize build output file. (core Kubernetes Namespace higher than ASO Namespace)

danielwilsonkainos avatar Nov 20 '23 16:11 danielwilsonkainos

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 20 '23 16:11 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: danielwilsonkainos / name: Daniel Wilson (ad5ca54cc7953e60515c673f818b7e74c6d273e7, cc96884e16e2bae6b0ab77f3b6dba460ef747e4c, a0985b122d5c3bef32c3d3fe1719f92beff49bda, 149aad5866dab6809585922ac5ca3fe5ecf1702a, 2beab4cc142d01938c836b67366696982d0e1d46)

Hi @danielwilsonkainos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 20 '23 16:11 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danielwilsonkainos Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 20 '23 16:11 k8s-ci-robot

For issue https://github.com/kubernetes-sigs/kustomize/issues/5457

danielwilsonkainos avatar Nov 20 '23 16:11 danielwilsonkainos

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 12 '24 18:03 k8s-triage-robot

/remove-lifecycle stale /retitle Sort built-in Namespace kind before CRDs with the same name /retest

stormqueen1990 avatar Mar 30 '24 23:03 stormqueen1990

/assign @koba1t for maintainer review

stormqueen1990 avatar Mar 30 '24 23:03 stormqueen1990

/ok-to-test

stormqueen1990 avatar Mar 30 '24 23:03 stormqueen1990

@danielwilsonkainos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kustomize-presubmit-master 2beab4cc142d01938c836b67366696982d0e1d46 link true /test kustomize-presubmit-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Mar 31 '24 00:03 k8s-ci-robot

@danielwilsonkainos could you please try rebasing this branch?

stormqueen1990 avatar Mar 31 '24 00:03 stormqueen1990