kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

feat: localize absolute paths

Open typeid opened this issue 1 year ago • 11 comments

Attempts to fix https://github.com/kubernetes-sigs/kustomize/issues/5275.

This PR adds handling of absolute paths to kustomize localize. To enable this, it converts the absolute paths to relative paths, keeping the rest of the processing chain intact.

Please let me know if anything's missing (e.g. documentation), or if this is going in the wrong direction. It's my first contribution here :)

typeid avatar Aug 25 '23 16:08 typeid

Welcome @typeid!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 25 '23 16:08 k8s-ci-robot

Hi @typeid. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 25 '23 16:08 k8s-ci-robot

@rayandas Could you give this PR a review?

natasha41575 avatar Sep 15 '23 18:09 natasha41575

@natasha41575 Sure. /assign

rayandas avatar Sep 15 '23 19:09 rayandas

Sorry for the delay.

/lgtm for me as well. Thank you!

ezzoueidi avatar Oct 09 '23 20:10 ezzoueidi

Thanks for your contribution! We'll try to get an approver to look at this in the next week or so.

natasha41575 avatar Oct 10 '23 18:10 natasha41575

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 26 '23 11:11 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 24 '24 12:02 k8s-triage-robot

/remove-lifecycle stale /auto-cc

stormqueen1990 avatar Feb 24 '24 13:02 stormqueen1990

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: typeid, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 30 '24 04:04 k8s-ci-robot