kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

Add the --no-verify flag to `kustomize localize`

Open annasong20 opened this issue 2 years ago • 8 comments

Eschewed features

  • [X] This issue is not requesting templating, unstuctured edits, build-time side-effects from args or env vars, or any other eschewed feature.

What would you like to have added?

Currently, the kustomize localize command does not give users the option to automatically run kustomize build to verify the localized copy before command return. This feature is documented in the command's KEP.

We would like to give users the option to specify the --no-verify flag for kustomize localize. When not specified, kustomize localize should run kustomize build on both the source Kustomization and localized copy and compare their output. When specified, the command should only localize, without running kustomize build.

Why is this needed?

This feature is needed to graduate kustomize localize to beta, as stated in the KEP.

Can you accomplish the motivating task without this feature, and if so, how?

It was agreed upon in the KEP that this feature would be a nice convenience to users.

What other solutions have you considered?

The localization works without this feature, but this helps users avoid the need to run kustomize localize, then kustomize build themselves to check.

Anything else we should know?

No response

Feature ownership

  • [ ] I am interested in contributing this feature myself! 🎉

annasong20 avatar Aug 18 '23 21:08 annasong20

/triage accepted

annasong20 avatar Aug 18 '23 21:08 annasong20

/assign

rayandas avatar Aug 23 '23 16:08 rayandas

Apologise for my recent inactivity, as I had to attend to some personal matters over the past couple of weeks. I'm now back and will continuing the implementation from where I left off last time.

rayandas avatar Oct 25 '23 17:10 rayandas

@rayandas Since there hasn't been activity in almost 3 months, I will unassign this issue and move it back to TODO so that someone else can work on it. If you are still interested in working on this issue, please feel free to open up a draft PR so that we can see the current progress. Thanks!

/unassign

natasha41575 avatar Nov 29 '23 18:11 natasha41575

/assign

ncapps avatar Dec 03 '23 02:12 ncapps

I haven't had time to make meaningful progress on this issue. I am unassigning myself in case someone else would like to pick it up.

/unassign

ncapps avatar Feb 01 '24 00:02 ncapps

/assign

sanaasy avatar Feb 01 '24 19:02 sanaasy

this issue has been completed!

sanaasy avatar Jun 12 '24 12:06 sanaasy

This has been done as part of #5544.

/close

stormqueen1990 avatar Aug 07 '24 14:08 stormqueen1990

@stormqueen1990: Closing this issue.

In response to this:

This has been done as part of #5544.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 07 '24 14:08 k8s-ci-robot