kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

update kyaml's dependency swag to v0.22.3

Open sunmin89 opened this issue 2 years ago • 6 comments

kyaml now depends on swag v0.19.14 which itself depends on https://github.com/niemeyer/pretty, this pretty package is a fork

of https://github.com/kr/pretty, the previous pretty is out of date,while the latter is maintained well,

swag v0.22.3 has already updated its dependency to kr's, I think it's necessary to update kyaml's too

thanks.

sunmin89 avatar Oct 12 '22 13:10 sunmin89

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: summer-dev (19d163ca0f42cc7941dedf1a7eb96a690bd38138, 1252e45576212d16fb3bf3ec244df46e65f8d14a)

Welcome @summer-dev!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Oct 12 '22 13:10 k8s-ci-robot

Hi @summer-dev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 12 '22 13:10 k8s-ci-robot

@summer-dev: This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 13 '22 01:10 k8s-ci-robot

Please sign the CLA

natasha41575 avatar Oct 14 '22 17:10 natasha41575

Please sign the CLA

Done,thanks for your remind :)

sunmin89 avatar Oct 17 '22 04:10 sunmin89

Thanks for your review @mengqiy @phanimarupaka

sunmin89 avatar Oct 21 '22 01:10 sunmin89

/ok-to-test /lgtm

natasha41575 avatar Oct 21 '22 18:10 natasha41575

/approve

natasha41575 avatar Oct 21 '22 18:10 natasha41575

@natasha41575

dear natasha41575 :

i'm confused about the failure reason of this sute : test-unit-non-plugin, it seems that some missed files are needed during testing.

image

i wonder where i can get these missed files? how can I solve this problem,

thanks

sunmin89 avatar Oct 24 '22 02:10 sunmin89

Hi @summer-dev I think that CI failure is caused by changing environment on GitHub Actions and that was fixed at https://github.com/kubernetes-sigs/kustomize/pull/4844. So, Could you try to rebase master?

koba1t avatar Nov 01 '22 18:11 koba1t

i wish another LGTM gift :)

sunmin89 avatar Nov 02 '22 02:11 sunmin89

Thanks, @summer-dev! Can I add a nit suggestion? Could you update libs for other places using a function of go workspace mode? That will work by typing the command to work sync!

/assign koba1t

koba1t avatar Nov 02 '22 04:11 koba1t

Hi, after executing

go work sync

About 90 files are modified, should I commit theses changes to my forked repo? and then waiting to be merged.

sunmin89 avatar Nov 02 '22 05:11 sunmin89

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, summer-dev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 02 '22 05:11 k8s-ci-robot

Hi @summer-dev

About 90 files are modified, should I commit theses changes to my forked repo?

Thanks! Please commit these files! So, I checked for tests on make test-unit-non-plugin and found one failed. I think this is caused by the docker build error on cmd/config/internal/commands/e2e/e2econtainerconfig/ dir.

I'm sorry for the inconvenience. Please exec go mod tidy on cmd/config/internal/commands/e2e/e2econtainerconfig/ dir?

koba1t avatar Nov 03 '22 16:11 koba1t

/lgtm

Hi @natasha41575 Could you recheck it and run GitHub actions?

koba1t avatar Nov 04 '22 04:11 koba1t