kustomize
kustomize copied to clipboard
kubernetes-sigs
feat: add remove configmap command
If someone need update the file list of the configMapGenerator from directory, they can use add configmap and remove configmap together.
Like this:
# Initialize
kustomize edit add configmap routes-01 --from-file="folder1/conf.d/*"
kustomize edit add configmap routes-02 --from-file="folder2/conf.d/*"
# Refresh configmap
kustomize edit remove configmap routes-01,routes-02
kustomize edit add configmap routes-01 --from-file="folder1/conf.d/*"
kustomize edit add configmap routes-01 --from-file="folder1/conf.d/*"
Closes #4493
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: yufeiminds / name: Yufei Li (0d7c56dcf8d0920f8cc86ac879dfc1da37162831)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @yufeiminds!
It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @yufeiminds. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yufeiminds: This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yufeiminds
Once this PR has been reviewed and has the lgtm label, please assign natasha41575 for approval by writing /assign @natasha41575 in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Yet another question, should we create a new pull request to support removing secrets? Because they are brothers. 😄
/lgtm
hi @natasha41575 This PR looks good to me, Could you exec tests and lint on GitHub actions?
This PR looks good to me, Could you exec tests and lint on GitHub actions?
Thanks for the review, and sorry for the delay! Running the tests now.
Hi, @koba1t
I have fixed the lint issues, there is an issue with testpackage linter. It will conflict with the remove_test package. So I create a nolint comment to ignore it. It may not affect the feature and code smell. If we need to fix it after that. I can create another pull request to fix all the commands of remove/remove_test package.
And @natasha41575, Could you exec tests and lint on GitHub actions again? Thank you~ 😄
It will conflict with the remove_test package.
Sorry, I didn't know that package already existed, and I think that it needs to clean up...
nolint:testpackage is used here and I think it permitted.
So, I think your fix is good. Thanks for your fix! /lgtm
Hi, @natasha41575, @koba1t. I resolved the conversations. Please push it forward again. Thank you~
@natasha41575 Hi, does this PR and #4872 could be merged?
I used my own modified version in our pipeline before it was merged. I am looking forward to it being integrated into the mainline as soon as possible. If any problems arise, please feel free to reach out to me. 😊
@stormqueen1990: changing LGTM is restricted to collaborators
In response to this:
LGTM! Just leaving a minor suggestion for the error message.
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: natasha41575, yufeiminds
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [natasha41575]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@yufeiminds The tests aren't triggering, I think because you created the PR before the tests ran. Can you push a commit address https://github.com/kubernetes-sigs/kustomize/pull/4796#discussion_r1313165717? I think that will trigger the tests.
@yufeiminds: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| kustomize-presubmit-master | 927804dfe58fff240e26e384a612947401089d04 | link | unknown | /test kustomize-presubmit-master |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@stormqueen1990: Closed this PR.
In response to this:
Closing this in favour of #5327
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.