kustomize
kustomize copied to clipboard
kubernetes-sigs
Improve invalid node kind errors
Also enhance this kind of error specifically in the namespace transformer, explaining to the user that it is probably a field spec issue. Also remove ignored field specs from that transformer's defaults, including two that are invalid in a way that would produce this message (but continuing to ignore the valid path).
@annasong20 was correct that it is the kyaml error package that is not working with errors.Is and errors.As. That is because it uses a very old version of its go-errors dependency, that didn't have go-1.13 style support. I think we are the reason k/k has this dep, and the diff to update all the way to latest is quite small in any case: https://github.com/go-errors/errors/compare/v1.0.1...v1.4.2.
/cc @natasha41575
@KnVerey: This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/hold for rebase on https://github.com/kubernetes-sigs/kustomize/pull/4704 when it merges (unless we change our mind about the order)
Deploy Preview for kubernetes-sigs-kustomize canceled.
| Name | Link |
|---|---|
| Latest commit | ffdb1edc78b8b2f3463f7d2315417088c5319529 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-kustomize/deploys/62e2deaa47440b000911e3a1 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
This has been rebased, but it might be good to hold until after the next release in case the dep upgrade unexpectedly is in fact an issue for kubectl.
Ah sorry I missed this PR
/lgtm /approve
I can retag if you need to rebase
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: KnVerey, natasha41575
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [KnVerey,natasha41575]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@natasha41575 I rebased and added two new commits: one making an improvement I couldn't do in #4754 because of the go-errors version, and another committing go.sum changes. PTAL.