Emit a warning on build when deprecated fields are used

[koba1t]

fix https://github.com/kubernetes-sigs/kustomize/issues/4706

[koba1t]

/assign @natasha41575

[k8s-ci-robot]

@koba1t: This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: koba1t Once this PR has been reviewed and has the lgtm label, please ask for approval from natasha41575 by writing /assign @natasha41575 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-kustomize canceled.

Name	Link
🔨 Latest commit	438758beaf179bb41d939a72c9a03991cfb0b799
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kustomize/deploys/62e3d749a7928e00089e5dbb

[koba1t]

hi @natasha41575 I think I completed fixing these. Could you recheck it?

[KnVerey]

I think it is better to merge first to https://github.com/kubernetes-sigs/kustomize/pull/4733 if I can. I added a warning message to patchesStrategicMerge in this PR.

I agree with you. So we don't forget that that order is required:

/hold for https://github.com/kubernetes-sigs/kustomize/pull/4733 to merge first

[koba1t]

Hi @KnVerey I think I completed to fix from your comment. If you have time, could you please recheck again?

[koba1t]

/remove-hold

[natasha41575]

Nice!

$ kustomize build > out
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [natasha41575]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[natasha41575]

/lgtm