kustomize
kustomize copied to clipboard
kubernetes-sigs
Support releaseNamespace argument with HelmChartInflationGenerator
Welcome @pxwxnvermx!
It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @pxwxnvermx. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pxwxnvermx
To complete the pull request process, please assign natasha41575 after the PR has been reviewed.
You can assign the PR to them by writing /assign @natasha41575 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@pxwxnvermx: Re-titling can only be requested by trusted users, like repository collaborators.
In response to this:
/retitle
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@pxwxnvermx: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
IIRC, kustomize is aimed at putting the built-in functions in a curated and stable status, and not expecting adding new features. Thus, it provides a render-helm-charts function which is more flexible to change. I'm not sure if we should extend this builtin helm or make the change in the other function. Maybe Katrina can give more context and guides here.
As for the helm release namespace config itself, by definition this field would set the namespace for a release, which conflicts with the kustomize namespace transformer. I think supporting this feature is sort of forcing kustomize to make another exception for helm which opens more black holes for other users. @pxwxnvermx please correct me if I misunderstand the use cases here. FYI, in which case that you need both kustomize and helm?
@yuwenma : I am not sure about the PR author, but in the original issue, you can see a number of folks who have use cases that are affected.
Generally, people (myself included) are using HelmChartInflationGenerator as a lightweight mechanism to embed well-supported Helm Charts in otherwise minimal installations. For example, if I create a test environment where I test a small application against the latest bitnami Helm Chart for a complex service e.g. Mongo. It might only be two or three manifests, and then the inflated helm chart.
This almost works, and is massively easier to create and maintain than implementing an entire CI workflow to render the helm chart in a pre-build step -- except for this one field not being propagated, which creates a non-functional rendering.
Perhaps you can comment on when there are situations where passing this field through would create a conflict with the namespace transformer?
If it is only potentially problematic in cases where someone is using the HelmChartInflationGenerator, then it would only affect use-cases which are already broken, so it would be better than the current state.
@yuwenma while you're right to be concerned about adding features to the Helm transformer, this change does fit within our long-term support plan, which you can read here: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/helmcharts/#long-term-support. Please note that we also accepted the linked issue in this case: https://github.com/kubernetes-sigs/kustomize/issues/4593#issuecomment-1183764375. Please do review the linked issue and this PR when you have a chance.
@KnVerey Thanks for the links. Yeah, the short term and long term plans are very reasonable. @pxwxnvermx Sorry for the confusions. reviewed 😃 !
@pxwxnvermx: This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pxwxnvermx
Once this PR has been reviewed and has the lgtm label, please assign natasha41575 for approval by writing /assign @natasha41575 in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@KnVerey @yuwenma any update on this? This fix is important for many kustomize users.
EDIT: @pxwxnvermx ?
I have no update on this PR. I am going to close this as I am not able to focus my time on this PR.