kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

migrate site content: contributing docs

Open dani-santos-code opened this issue 3 years ago • 9 comments

This PR is part of the larger docs consolidation issue: https://github.com/kubernetes-sigs/kustomize/issues/4338

I copied over the files from cli-experimental, ran locally and it seems to be correct

Screen Shot 2022-07-13 at 9 56 03 PM

I followed a similar pattern we see in this other migration PR

dani-santos-code avatar Jul 14 '22 01:07 dani-santos-code

@dani-santos-code: This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 14 '22 01:07 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: dani-santos-code / name: Dani Santos (25e4b510d8883714b0efbf8d7ae2984ea92b6b96, 4ace48f183f457b88c7b21f5c4e6c04cc12e0839)

Welcome @dani-santos-code!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 14 '22 01:07 k8s-ci-robot

Hi @dani-santos-code. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 14 '22 01:07 k8s-ci-robot

/ok-to-test

natasha41575 avatar Jul 15 '22 22:07 natasha41575

@KnVerey Would it be possible to set up a netlify preview in CI like we have in cli-experimental here?

natasha41575 avatar Jul 15 '22 22:07 natasha41575

@KnVerey Would it be possible to set up a netlify preview in CI like we have in cli-experimental here?

I want to make sure we don't publish the site "for real" anywhere before it is ready, but you're right that the preview would be very handy. I've put in a request at https://github.com/kubernetes/org/issues/3564. If it is approved, we will need to figure out how to disable deploys off the master branch (or failing that, disable crawlers).

KnVerey avatar Jul 19 '22 18:07 KnVerey

thank you for your feedback @natasha41575. I think I addressed most of your feedback. Would appreciate a re-review. Thank you! 🙏

dani-santos-code avatar Jul 21 '22 18:07 dani-santos-code

/tide merge-method-squash

KnVerey avatar Sep 29 '22 17:09 KnVerey

/label tide/merge-method-squash

KnVerey avatar Sep 29 '22 17:09 KnVerey

/lgtm /approve

KnVerey avatar Sep 29 '22 17:09 KnVerey

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dani-santos-code, KnVerey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 29 '22 17:09 k8s-ci-robot