kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

From #4256 #3816 this introduces support for kube-version parameter

Open daconstenla opened this issue 3 years ago • 7 comments

To be able to consume helm templates that rely on Capabilities the --kube-version flag has to be supported. This pr is introducing that configuration flag on kustommization.yml level under helmCharts, eg:

- name: reloader
  version: '0.0.113'
  repo: https://stakater.github.io/stakater-charts
  releaseName: reloader
  namespace: reloader
  kubeVersion: '1.21'
  valuesInline:
    # https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/values.yaml
    fullnameOverride: reloader
    reloader:
      deployment:
        replicas: 1
        resources:
          limits:
            cpu: "100m"
            memory: "512Mi"
          requests:
            cpu: "10m"
            memory: "128Mi"
      containerSecurityContext:
        capabilities:
          drop:
            - ALL
        allowPrivilegeEscalation: false
        readOnlyRootFilesystem: true
      service:
        port: 9090
      serviceMonitor:
        enabled: true
        namespace: reloader

relates to #4256 and #3816

I've executed make verify-kustomize-repo successfully and make test-unit-kustomize-plugins:

Testing ./plugin/builtin/helmchartinflationgenerator
=== RUN   TestHelmChartInflationGenerator
2022/06/07 17:05:44 compiler created: /Users/dconstenla/gitClones/kustomize/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.so
    HelmChartInflationGenerator_test.go:20: skipping: exec: "helmV3": executable file not found in $PATH
--- SKIP: TestHelmChartInflationGenerator (2.36s)
=== RUN   TestHelmChartInflationGeneratorWithValuesInlineOverride
2022/06/07 17:05:47 compiler created: /Users/dconstenla/gitClones/kustomize/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.so
    HelmChartInflationGenerator_test.go:367: skipping: exec: "helmV3": executable file not found in $PATH
--- SKIP: TestHelmChartInflationGeneratorWithValuesInlineOverride (2.24s)
=== RUN   TestHelmChartInflationGeneratorWithLocalValuesFile
2022/06/07 17:05:49 compiler created: /Users/dconstenla/gitClones/kustomize/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.so
    HelmChartInflationGenerator_test.go:398: skipping: exec: "helmV3": executable file not found in $PATH
--- SKIP: TestHelmChartInflationGeneratorWithLocalValuesFile (2.27s)
=== RUN   TestHelmChartInflationGeneratorWithInLineReplace
2022/06/07 17:05:51 compiler created: /Users/dconstenla/gitClones/kustomize/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.so
    HelmChartInflationGenerator_test.go:435: skipping: exec: "helmV3": executable file not found in $PATH
--- SKIP: TestHelmChartInflationGeneratorWithInLineReplace (2.22s)
=== RUN   TestHelmChartInflationGeneratorWithIncludeCRDs
2022/06/07 17:05:53 compiler created: /Users/dconstenla/gitClones/kustomize/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.so
    HelmChartInflationGenerator_test.go:471: skipping: exec: "helmV3": executable file not found in $PATH
--- SKIP: TestHelmChartInflationGeneratorWithIncludeCRDs (2.24s)
=== RUN   TestHelmChartInflationGeneratorWithExcludeCRDs
2022/06/07 17:05:56 compiler created: /Users/dconstenla/gitClones/kustomize/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.so
    HelmChartInflationGenerator_test.go:505: skipping: exec: "helmV3": executable file not found in $PATH
--- SKIP: TestHelmChartInflationGeneratorWithExcludeCRDs (2.24s)
=== RUN   TestHelmChartInflationGeneratorWithIncludeCRDsNotSpecified
2022/06/07 17:05:58 compiler created: /Users/dconstenla/gitClones/kustomize/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.so
    HelmChartInflationGenerator_test.go:534: skipping: exec: "helmV3": executable file not found in $PATH
--- SKIP: TestHelmChartInflationGeneratorWithIncludeCRDsNotSpecified (2.27s)
PASS
ok      command-line-arguments  16.457s

daconstenla avatar Jun 07 '22 14:06 daconstenla

Welcome @daconstenla!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jun 07 '22 14:06 k8s-ci-robot

Hi @daconstenla. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 07 '22 14:06 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daconstenla To complete the pull request process, please assign knverey after the PR has been reviewed. You can assign the PR to them by writing /assign @knverey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 07 '22 14:06 k8s-ci-robot

@daconstenla: This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 08 '22 08:06 k8s-ci-robot

/label tide/merge-method-squash

daconstenla avatar Jun 08 '22 08:06 daconstenla

Can you please rebase and add test coverage for the new fields/flags this PR adds support for?

KnVerey avatar Aug 12 '22 20:08 KnVerey

@daconstenla: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 11 '22 02:10 k8s-ci-robot

Run into a problem with exactly this issue. Helm Chart with kubeVersion: >=1.18.0-0 <1.25.0-0 could not be applied on my 1.24 cluster.

What can I do help this push forward?

mikevader avatar Nov 23 '22 10:11 mikevader

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 21 '23 10:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 23 '23 10:03 k8s-triage-robot

@daconstenla - are you still intending to work on this? It still needs a rebase and test coverage for for the new fields/flags.

cailyn-codes avatar Mar 23 '23 19:03 cailyn-codes

Closing this PR in favour of issue: #5112

cailyn-codes avatar Mar 27 '23 17:03 cailyn-codes

/close

cailyn-codes avatar Mar 27 '23 17:03 cailyn-codes

@cailynse: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 27 '23 17:03 k8s-ci-robot