kustomize add: "edit add labels" command adds an option for labels without selector

kustomize edit add labels command only support adding commonLabels now. But, commonLabels inject labels in selector fields (like spec.selector.matchLabels ).

I want to add labels without injecting corresponding selectors with a command (using a labels field).
Therefore I add an option for labels without selector for kustomize edit add labels command.

Feb 24 '22 01:02 koba1t

Hi @koba1t. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Feb 24 '22 01:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: koba1t To complete the pull request process, please assign natasha41575 after the PR has been reviewed. You can assign the PR to them by writing /assign @natasha41575 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Feb 24 '22 01:02 k8s-ci-robot

Sounds similar to #4478, might be worth reviewing and merging both together as part of the same release.

Feb 25 '22 14:02 gaeljw

Could you review it?

/assign @natasha41575

Mar 08 '22 10:03 koba1t

/assign @yuwenma

Mar 16 '22 01:03 koba1t

I agree that this is duplicating functionality of https://github.com/kubernetes-sigs/kustomize/pull/4478, which I'm leaning towards accepting. Appreciate your PR and will keep you updated! That one needs a few changes.

Apr 13 '22 20:04 natasha41575

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Oct 06 '22 22:10 k8s-triage-robot

/remove-lifecycle stale

Oct 07 '22 04:10 koba1t

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jan 05 '23 04:01 k8s-triage-robot

/remove-lifecycle stale

Jan 05 '23 04:01 koba1t

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Apr 05 '23 04:04 k8s-triage-robot

/remove-lifecycle stale

Apr 05 '23 06:04 koba1t

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jul 04 '23 07:07 k8s-triage-robot

/remove-lifecycle stale

Jul 04 '23 07:07 koba1t

/ok-to-test

Sorry @koba1t, this fell off our radar. I'm adding it to the project board.

Aug 18 '23 17:08 natasha41575

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezzoueidi, koba1t, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [natasha41575]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Sep 22 '23 16:09 k8s-ci-robot