kustomize icon indicating copy to clipboard operation
kustomize copied to clipboard

kustomize edit add resource remoteurl shouldn't require validation

Open james-callahan opened this issue 4 years ago • 16 comments

Running kustomize edit add resource [email protected]/myorg/myrepo/kustomize/base?ref=abcdef shouldn't require network connectivity or permission to the repo. We generate some of our kustomizations in a locked down environment that doesn't have a valid key to the relevant repository. Additionally, (and especially for non-locked references e.g. ?ref=master), what may be valid today may not be valid later, and vice versa: I may be creating the kustomization before pushing.

One possible solution would be adding a flag such as --validate=false that just assumes the resource is valid and skips the network access

Additional context

  • kustomize edit add was added in #2768

james-callahan avatar Nov 25 '20 04:11 james-callahan

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Feb 25 '21 04:02 fejta-bot

/remove-lifecycle stale

james-callahan avatar Feb 25 '21 04:02 james-callahan

/assign

ChaturvediSulabh avatar May 02 '21 16:05 ChaturvediSulabh

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

k8s-triage-robot avatar Jul 31 '21 17:07 k8s-triage-robot

/remove-lifecycle stale

@ChaturvediSulabh did you get anywhere with this?

james-callahan avatar Aug 01 '21 11:08 james-callahan

@james-callahan, Have received feedback just last week, working on implementing changes. Apologies for the delay, however, looking at the comments, this might take some more time.

ChaturvediSulabh avatar Aug 04 '21 13:08 ChaturvediSulabh

I'll try to finish the work by this weekend. Apologies for the delay.

ChaturvediSulabh avatar Sep 16 '21 08:09 ChaturvediSulabh

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 15 '21 09:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 14 '22 09:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Feb 13 '22 10:02 k8s-triage-robot

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 13 '22 10:02 k8s-ci-robot

/reopen

james-callahan avatar Aug 22 '22 08:08 james-callahan

@james-callahan: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 22 '22 08:08 k8s-ci-robot

/remove-lifecycle rotten /lifecycle frozen /help

natasha41575 avatar Aug 22 '22 14:08 natasha41575

@natasha41575: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/remove-lifecycle rotten /lifecycle frozen /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 22 '22 14:08 k8s-ci-robot

Any progress on this?

nikita-akuity avatar Oct 02 '22 22:10 nikita-akuity

/assign

hailkomputer avatar Aug 23 '23 16:08 hailkomputer

Just approved https://github.com/kubernetes-sigs/kustomize/pull/5333, so closing this issue now. The --no-verify flag will be available in the next release.

natasha41575 avatar Oct 06 '23 17:10 natasha41575