Allow mutating queue-name label in LeaderWorkerSet.

[mbobrovskyi]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow mutating queue-name label in LeaderWorkerSet.

Which issue(s) this PR fixes:

Fixes #4967

Special notes for your reviewer:

We already have the same logic on Deployment and StatefulSet.

https://github.com/kubernetes-sigs/kueue/blob/8dabaab58c4ede8adbddbee9053f2247ec9ec97e/pkg/controller/jobs/deployment/deployment_webhook.go#L129-L133

https://github.com/kubernetes-sigs/kueue/blob/8dabaab58c4ede8adbddbee9053f2247ec9ec97e/pkg/controller/jobs/statefulset/statefulset_webhook.go#L139-L143

Does this PR introduce a user-facing change?

Allow mutating the queue-name in LeaderWorkerSet when ReadyReplicas is zero

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	9d4b11acb9577bca63bdceff837534c27adf54f8
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6858fc882095c90008bfe4b4

[mimowo]

/hold As for https://github.com/kubernetes-sigs/kueue/pull/4918, I don't have capacity to review this for 0.12, and it is low priority as we don't have yet users asking for it.

[mimowo]

@mbobrovskyi can you please describe the changes done since 249f006, because I see updates to code, but not to the e2e test. So, I have questions because: Are the recent updates are required? are the recent updates due to a n initial bug? If there was a bug can we cover it with tests?

[mbobrovskyi]

@mbobrovskyi can you please describe the changes done since 249f006, because I see updates to code, but not to the e2e test. So, I have questions because: Are the recent updates are required? are the recent updates due to a n initial bug? If there was a bug can we cover it with tests?

Yeah, I missed adding this test case – it’s added now.

[mszadkow]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 63b0085465b4ecf08e38bf9ffe5f9bd039be1e45

[mbobrovskyi]

/cc @mimowo

[mimowo]

/hold This is a tricky feature, and relatively low priority, so I'm very careful about it. And I see tests for mutating queue-name for STS are flaky: https://github.com/kubernetes-sigs/kueue/issues/5041. Let's investigate that first, because I think the mechanics is very similar.

Also, can you confirm locally the new e2e test is not flaky? I would suggest something like 100 repeats under some extra load / stress.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

@mbobrovskyi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kueue-test-unit-main	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-unit-main
pull-kueue-test-e2e-customconfigs-main	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-e2e-customconfigs-main
pull-kueue-test-e2e-main-1-30	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-e2e-main-1-30
pull-kueue-test-e2e-main-1-33	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-e2e-main-1-33
pull-kueue-test-e2e-main-1-32	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-e2e-main-1-32
pull-kueue-test-e2e-main-1-31	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-e2e-main-1-31
pull-kueue-test-e2e-main-1-34	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-e2e-main-1-34
pull-kueue-test-e2e-certmanager-upgrade-main	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-e2e-certmanager-upgrade-main
pull-kueue-test-e2e-upgrade-main	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-test-e2e-upgrade-main
pull-kueue-populator-test-unit-main	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-populator-test-unit-main
pull-kueue-populator-test-e2e-main	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-populator-test-e2e-main
pull-kueue-populator-verify-main	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-populator-verify-main
pull-kueue-populator-test-integration-main	9d4b11acb9577bca63bdceff837534c27adf54f8	link	true	/test pull-kueue-populator-test-integration-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.