kueue
kueue copied to clipboard
Add test cases for multiple podsets
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds the test for multiple podsets in TestFindTopologyAssignment to improve coverage and ensure comprehensive validation of FindTopologyAssignment.
Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes-sigs/kueue/issues/4549#event-16802169139
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Hi @Horiodino. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-kueue ready!
| Name | Link |
|---|---|
| Latest commit | f18a022227edab8db09bba74f51c076a9d6fd579 |
| Latest deploy log | https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6895f03512ea510008e152ae |
| Deploy Preview | https://deploy-preview-4710--kubernetes-sigs-kueue.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
/milestone v0.12
/ok-to-test Thank you for driving this!
Hi @Horiodino, could you rebase the branch so we can proceed with the PR?
Hi @Horiodino, could you rebase the branch so we can proceed with the PR?
Hey, sorry for the delay , I had exams and then went on vacation. I'll get it fixed soon .
Thanks @Horiodino, /lgtm
LGTM label has been added.
Hey, could anyone please review this PR soon? Itβs been stale for a while, and with so many changes, itβs starting to develop conflicts.
cc @PBundyra
/lgtm Thanks @Horiodino
LGTM label has been added.
cc @mimowo @tenzen-y
/lgtm /approve
thanks!!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gabesaba, Horiodino
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [gabesaba]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment