kueue icon indicating copy to clipboard operation
kueue copied to clipboard

Add test cases for multiple podsets

Open Horiodino opened this issue 8 months ago β€’ 7 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds the test for multiple podsets in TestFindTopologyAssignment to improve coverage and ensure comprehensive validation of FindTopologyAssignment.

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/kueue/issues/4549#event-16802169139

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Horiodino avatar Mar 20 '25 11:03 Horiodino

Hi @Horiodino. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Mar 20 '25 11:03 k8s-ci-robot

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit f18a022227edab8db09bba74f51c076a9d6fd579
Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6895f03512ea510008e152ae
Deploy Preview https://deploy-preview-4710--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Mar 20 '25 11:03 netlify[bot]

/milestone v0.12

mimowo avatar Mar 20 '25 15:03 mimowo

/ok-to-test Thank you for driving this!

mimowo avatar Mar 21 '25 05:03 mimowo

Hi @Horiodino, could you rebase the branch so we can proceed with the PR?

PBundyra avatar May 28 '25 09:05 PBundyra

Hi @Horiodino, could you rebase the branch so we can proceed with the PR?

Hey, sorry for the delay , I had exams and then went on vacation. I'll get it fixed soon .

Horiodino avatar Jun 16 '25 16:06 Horiodino

Thanks @Horiodino, /lgtm

PBundyra avatar Jul 29 '25 14:07 PBundyra

LGTM label has been added.

Git tree hash: 38d914066d4743c1bf66502a50de27b718cb6a44

k8s-ci-robot avatar Jul 29 '25 14:07 k8s-ci-robot

Hey, could anyone please review this PR soon? It’s been stale for a while, and with so many changes, it’s starting to develop conflicts.

Horiodino avatar Aug 08 '25 13:08 Horiodino

cc @PBundyra

Horiodino avatar Aug 11 '25 16:08 Horiodino

/lgtm Thanks @Horiodino

PBundyra avatar Aug 12 '25 07:08 PBundyra

LGTM label has been added.

Git tree hash: 9f2bb4ef6269508cd1369500716902011ab827a1

k8s-ci-robot avatar Aug 12 '25 07:08 k8s-ci-robot

cc @mimowo @tenzen-y

PBundyra avatar Aug 12 '25 07:08 PBundyra

/lgtm /approve

thanks!!

gabesaba avatar Aug 13 '25 13:08 gabesaba

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabesaba, Horiodino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 13 '25 13:08 k8s-ci-robot