kueue
kueue copied to clipboard
kubernetes-sigs
Allow to delete queue-name on deployment.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allow to delete queue-name on deployment.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Deploy Preview for kubernetes-sigs-kueue canceled.
| Name | Link |
|---|---|
| Latest commit | bb452fdd0d52e45f03f3e28dfff081428bc2c0c5 |
| Latest deploy log | https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68542a9b9029740008542ed5 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mbobrovskyi Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/unhold
Due to https://github.com/kubernetes-sigs/kueue/pull/4784 was merged.
What's the context for this change @mbobrovskyi?
The idea is to allow users to remove the queue-name label from a Deployment if deployment.status.readyReplicas == 0. This is similar to the logic in GenericJob, where we allow removal of the queue-name label if the Job is suspended.
LGTM label has been added.
What's the context for this change @mbobrovskyi?
I would add to the context that this is a "best effort" feature as we don't yet have users asking for this. The use is very limited. Still, we probably want to do it for consistency with Jobs, but I wouldn't rush with this, because it is actually tricky,
This feature is low priority for 0.12 (no users requesting) for the moment - yet it is tricky, so I will review it only "best effort", once the comments are addressed and there is e2e test.
This needs more adjustments to take into account the presence of the LQ "default", see https://github.com/kubernetes-sigs/kueue/pull/5451
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@mbobrovskyi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kueue-test-multikueue-integration-main | 065efeb2e9e605bb08cbf0a89b77651497c8060e | link | true | /test pull-kueue-test-multikueue-integration-main |
| pull-kueue-test-customconfigs-e2e-main | 065efeb2e9e605bb08cbf0a89b77651497c8060e | link | true | /test pull-kueue-test-customconfigs-e2e-main |
| pull-kueue-test-e2e-upgrade-main | bb452fdd0d52e45f03f3e28dfff081428bc2c0c5 | link | true | /test pull-kueue-test-e2e-upgrade-main |
| pull-kueue-test-e2e-certmanager-upgrade-main | bb452fdd0d52e45f03f3e28dfff081428bc2c0c5 | link | true | /test pull-kueue-test-e2e-certmanager-upgrade-main |
| pull-kueue-populator-test-unit-main | bb452fdd0d52e45f03f3e28dfff081428bc2c0c5 | link | true | /test pull-kueue-populator-test-unit-main |
| pull-kueue-populator-test-e2e-main | bb452fdd0d52e45f03f3e28dfff081428bc2c0c5 | link | true | /test pull-kueue-populator-test-e2e-main |
| pull-kueue-populator-verify-main | bb452fdd0d52e45f03f3e28dfff081428bc2c0c5 | link | true | /test pull-kueue-populator-verify-main |
| pull-kueue-populator-test-integration-main | bb452fdd0d52e45f03f3e28dfff081428bc2c0c5 | link | true | /test pull-kueue-populator-test-integration-main |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.