kueue icon indicating copy to clipboard operation
kueue copied to clipboard

HierarchicalCohort: Remove unused status field

Open tenzen-y opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The cohortStatus field is always empty. To avoid confusing, removing unneeded field would be better. Similar reason: https://github.com/kubernetes-sigs/kueue/pull/3305

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

tenzen-y avatar Oct 24 '24 17:10 tenzen-y

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit 839403143dec16f5134ad88ebd27b3bd6a5c3c43
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/671a85fe895f160008771bc7
Deploy Preview https://deploy-preview-3311--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 24 '24 17:10 netlify[bot]

/lgtm /approve Let's re-add it when needed. cc @gabesaba

mimowo avatar Oct 25 '24 10:10 mimowo

LGTM label has been added.

Git tree hash: 79a89b1c7aa1192b846bc69df8279a556cd21757

k8s-ci-robot avatar Oct 25 '24 10:10 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [mimowo,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 25 '24 10:10 k8s-ci-robot