kueue icon indicating copy to clipboard operation
kueue copied to clipboard

[KEP] Extend `WaitForPodsReady` config by `.waitForAdmissionChecks` field

Open PBundyra opened this issue 1 year ago • 6 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Describes API extension for WaitForPodsReady which expands it's functionality to AdmissionChecks, to prevent wasteful allocation of resources and starvation.

Which issue(s) this PR fixes:

Part of #3231

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

PBundyra avatar Oct 14 '24 13:10 PBundyra

/assign @mimowo cc @mwielgus

PBundyra avatar Oct 14 '24 13:10 PBundyra

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit c27dc8a510d7154f5ffbe2e98828ddf9963852d0
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/670d352a7b66de00082528ed

netlify[bot] avatar Oct 14 '24 13:10 netlify[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PBundyra Once this PR has been reviewed and has the lgtm label, please ask for approval from mimowo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 14 '24 13:10 k8s-ci-robot

/cc

@mimowo @PBundyra Will this be marked as a must-have for the next release? I need to prioritize features for the next releases on my side.

tenzen-y avatar Oct 14 '24 14:10 tenzen-y

/cc

@mimowo @PBundyra Will this be marked as a must-have for the next release? I need to prioritize features for the next releases on my side.

It shouldn't block the release, but it's a strong nice-to-have

PBundyra avatar Oct 14 '24 15:10 PBundyra

It shouldn't block the release, but it's a strong nice-to-have

I see. It seems that there are a few strong nice-to-have...

tenzen-y avatar Oct 14 '24 16:10 tenzen-y