kueue icon indicating copy to clipboard operation
kueue copied to clipboard

Make LossLessDefaulter selective to only prevent dropping fields outside of schema

Open mimowo opened this issue 1 year ago • 4 comments

What would you like to be added:

Investigate making the LossLessDefaulter in Kueue to only prevent dropping fields outside of schema. This is a follow up from the discussion: https://github.com/kubernetes-sigs/kueue/pull/3132#discussion_r1782255326

And follow up to the issue: https://github.com/kubernetes-sigs/kueue/issues/2878

Why is this needed:

  • Long term we may want to remove some fields in Kueue webhooks, and it would be hard with the current LossLessDefaulter
  • Making LossLessDefaulter selective could possibly let us promote it as an opt-in defaulter in controller-runtime, allowing for:
    • reduced maintenance cost by moving from Kueue to controller-runtime
    • allow sharing the solution with other projects so that they don't need to reinvent the wheel

Completion requirements:

Investigate if this is feasible. and what is the implementation complexity, prototype.

mimowo avatar Oct 01 '24 17:10 mimowo

/assign @tenzen-y per comment https://github.com/kubernetes-sigs/kueue/pull/3132#discussion_r1783163941 /cc @alculquicondor

mimowo avatar Oct 01 '24 17:10 mimowo

Sorry. I did not want to indicate taking this issue. /unassign

tenzen-y avatar Oct 01 '24 17:10 tenzen-y

Sorry, I misread your message which was clear. Thanks for clarifying! Anyway, the issue is open for contributions.

mimowo avatar Oct 02 '24 06:10 mimowo

/assign

mbobrovskyi avatar Oct 03 '24 05:10 mbobrovskyi

/close we don't need this in Kueue as there is fix in controller-runtime to be released, issue to track using the fix: https://github.com/kubernetes-sigs/kueue/issues/3469

mimowo avatar Nov 07 '24 09:11 mimowo

@mimowo: Closing this issue.

In response to this:

/close we don't need this in Kueue as there is fix in controller-runtime to be released, issue to track using the fix: https://github.com/kubernetes-sigs/kueue/issues/3469

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 07 '24 09:11 k8s-ci-robot