kueue icon indicating copy to clipboard operation
kueue copied to clipboard

Remove webhook builder when controller-runtime allows overriding a mutation handler

Open alculquicondor opened this issue 1 year ago • 1 comments

What would you like to be cleaned:

Remove pkg/controller/jobframework/webhook/builder.go when https://github.com/kubernetes-sigs/controller-runtime/pull/2932 is merged and released.

Why is this needed:

We duplicated the file to be able to provide a fix in Kueue faster in #3132

alculquicondor avatar Sep 25 '24 15:09 alculquicondor

Do not assign this issue yet, because #3132 is not merged yet.

alculquicondor avatar Sep 25 '24 15:09 alculquicondor

Closing in favor of https://github.com/kubernetes-sigs/kueue/issues/3469, as with the controller-runtime fix we can drop also our defaulter altogether.

mimowo avatar Nov 06 '24 08:11 mimowo

/close

mimowo avatar Nov 06 '24 08:11 mimowo

@mimowo: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 06 '24 08:11 k8s-ci-robot