Cleanup manipulation of CQ/Cohort resource accounting in tests

[vladikkuzn]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2749

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[vladikkuzn]

/assign

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	48760104cabd7c4042a46475ceac712ff1954d33
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/672242a64159180008433c7c
😎 Deploy Preview	https://deploy-preview-2889--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[vladikkuzn]

/ok-to-test

[vladikkuzn]

/cc @gabesaba

[gabesaba]

This was not the part of flavorassigner_test which needed refactoring. It is in particular this that we want to delete: https://github.com/kubernetes-sigs/kueue/blob/c257cc03b0d86c6fac29e851de07a29c02e30ec8/pkg/scheduler/flavorassigner/flavorassigner_test.go#L1961-L1962

We want to avoid overriding these fields manually, instead indirectly set this usage/capacity via ClusterQueues. See https://github.com/kubernetes-sigs/kueue/issues/2502#issuecomment-2228679747

[gabesaba]

Additionally this https://github.com/kubernetes-sigs/kueue/blob/c257cc03b0d86c6fac29e851de07a29c02e30ec8/pkg/scheduler/flavorassigner/flavorassigner_test.go#L1964

All the usage can be manipulated by calling ClusterQueueSnapshot.AddUsage.

Cohort resources can be added via the main test CQ, and in some cases, a secondary test CQ which lends resources and does nothing else

[vladikkuzn]

/cc @mszadkow

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vladikkuzn Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[mszadkow]

/retest

[mszadkow]

I have a feeling that some test cases names are confusing. Tests work with one cluster but the test case is "lend", isn't lending between the clusterqueues? E.g. "lend try next flavor, found the second flavor" wdyt @vladikkuzn @mbobrovskyi @gabesaba ?

[mbobrovskyi]

I have a feeling that some test cases names are confusing. Tests work with one cluster but the test case is "lend", isn't lending between the clusterqueues? E.g. "lend try next flavor, found the second flavor" wdyt @vladikkuzn @mbobrovskyi @gabesaba ?

Or invalid test case.

[mszadkow]

I have a feeling that some test cases names are confusing. Tests work with one cluster but the test case is "lend", isn't lending between the clusterqueues? E.g. "lend try next flavor, found the second flavor" wdyt @vladikkuzn @mbobrovskyi @gabesaba ?

Or invalid test case.

I will take closer look it's only 4 of them.

[mszadkow]

@gabesaba @vladikkuzn that's another PR that only addresses cohortResource issue: https://github.com/kubernetes-sigs/kueue/pull/3398

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mszadkow]

@vladikkuzn you can close this one I believe