kubernetes-sigs
feat: allow customizable [Mutating|Validating]WebhookConfiguration names
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
closes #2750
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: davidxia Once this PR has been reviewed and has the lgtm label, please assign alculquicondor for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @davidxia. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-kueue ready!
| Name | Link |
|---|---|
| Latest commit | 8e87d8b29634e573437221e57066b1f7ef162563 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66abe681a366a70008a43ddf |
| Deploy Preview | https://deploy-preview-2751--kubernetes-sigs-kueue.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@denkensk @mimowo are you open to this small feature? If so, how does this implementation look?
I'm not sure, let me ask some questions to better understand the feature and your use case.
Do you want to replace the built-in webhooks with custom ones?
Which part is really important for you - disabling the built-in ones, or the ability to register extra ones?
If so, what is the issue with the built-in ones, can we extend them?
cc @tenzen-y
Do you want to replace the built-in webhooks with custom ones?
No, I just want to be able to specify a custom name for the Validating and MutatingWebhookConfigurations.
No, I just want to be able to specify a custom name for the Validating and MutatingWebhookConfigurations.
Ok, but then why?
Just a side note that the names are hard-coded in the helm charts see here.
Ok, but then why?
I'm deploying the helm charts with ArgoCD to multiple K8s clusters. ArgoCD itself runs on one K8s cluster. Each helm chart deployment is created by an ArgoCD Application K8s custom resource. These Applications need to have unique names. So I prefix them with the target K8s cluster name as a prefix. e.g. cluster1-kueue, cluster2-kueue.
Without being able to customize the webhook name, I get K8s resource name mismatches because of this cluster prefix.
Just a side note that the names are hard-coded in the helm charts see here.
ArgoCD is able to update the Helm chart names somehow. So I see all the K8s resource names are prefixed as I expect. It's just the hard-coded names in Golang that aren't matching.
Thanks for explaining. I need some time to digest, as I'm not quite familiar with helm charts yet.
In the meanwhile let's see if @tenzen-y or @mwielgus has some thoughts on this
Maybe I couldn't understand your use cases property. Are there any reasons why you do not prefer using the ApplicationSet instead of the Application to deploy ArgoCD Applications to the multiplier clusters?
Maybe I couldn't understand your use cases property. Are there any reasons why you do not prefer using the ApplicationSet instead of the Application to deploy ArgoCD Applications to the multiplier clusters?
We are locked into a legacy system that uses Applications. Does ApplicationSet support what we need?
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.