kueue icon indicating copy to clipboard operation
kueue copied to clipboard

Fixed prefixes on comments.

Open mbobrovskyi opened this issue 1 year ago • 5 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Regarding https://go.dev/wiki/CodeReviewComments#comment-sentences suggestion, comments should begin with the name of the thing being described and end in a period.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

mbobrovskyi avatar Jul 04 '24 07:07 mbobrovskyi

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit dda5f0271cd444b7045449cf81d0246eca3b04bd
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6687b08c26f89e0008964a2c

netlify[bot] avatar Jul 04 '24 07:07 netlify[bot]

LGTM label has been added.

Git tree hash: 969a21245b615a863b5613e7874e0ccbb9752409

k8s-ci-robot avatar Jul 04 '24 13:07 k8s-ci-robot

/assign @alculquicondor

trasc avatar Jul 04 '24 13:07 trasc

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 04 '24 14:07 k8s-ci-robot

/hold for the claryfication

alculquicondor avatar Jul 04 '24 14:07 alculquicondor

/unhold /lgtm

trasc avatar Jul 05 '24 08:07 trasc

LGTM label has been added.

Git tree hash: 39b1baca32fee4f5c99edf84e8db721be81f00ce

k8s-ci-robot avatar Jul 05 '24 08:07 k8s-ci-robot