kueue
kueue copied to clipboard
Define ClusterQueueSnapshot and CohortSnapshot types
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Preparation for #79. Create Snapshot types for CQ and Cohort, to better differentiate between Cache types. We were currently relying on fields properly being set/copied, and some fields not being set.
This change will make the code easier to understand and less error prone.
Special notes for your reviewer:
Unexporting Cohort/ClusterQueue works trivially. I will send this out in a subsequent PR.
Additionally, I didn't move methods that operate on ClusterQueueSnapshot to the new file, to keep the diff smaller. These can be moved in a subsequent PR if we wish.
Also folding https://github.com/kubernetes-sigs/kueue/pull/2489 into this change.
Does this PR introduce a user-facing change?
NONE
Deploy Preview for kubernetes-sigs-kueue canceled.
| Name | Link |
|---|---|
| Latest commit | b7ecfe7b40381eb8e3500988bf0d6ce0192577ec |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66880d311c7f2c00080792b1 |
/lgtm /approve
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alculquicondor, gabesaba
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [alculquicondor]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test pull-kueue-test-e2e-main-1-28 /test pull-kueue-test-e2e-main-1-30 Looks like overloaded infra: "There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors" link