kueue
kueue copied to clipboard
kubernetes-sigs
support running workloads in visibility endpoint
What type of PR is this?
/kind feature
What this PR does / why we need it:
support running workloads in visibility endpoint
Which issue(s) this PR fixes:
Fixes #1776
Special notes for your reviewer:
Does this PR introduce a user-facing change?
We will add a new visibility endpoint in Kueue. Users can list the running workloads by using
'kubectl get --raw "/apis/visibility.kueue.x-k8s.io/v1alpha1/clusterqueues/cluster-queue/runningworkloads"'
and
'kubectl get --raw "/apis/visibility.kueue.x-k8s.io/v1alpha1/namespaces/default/localqueues/user-queue/runningworkloads"'
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: KunWuLuan Once this PR has been reviewed and has the lgtm label, please assign alculquicondor for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @KunWuLuan. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-kueue canceled.
| Name | Link |
|---|---|
| Latest commit | 8d7f709225bb828c38758a22ccf892f304b1bd0c |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/664c95d26939a50008f1a91a |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
do we need to query running workloads for local queues?
I am leaning towards implementing that. It will be useful for the KueueCtl. It might be a separate PR though @alculquicondor @mwielgus WDYT?
do we need to query running workloads for local queues?
I am leaning towards implementing that. It will be useful for the KueueCtl. It might be a separate PR though
Yes, a separate PR would be better.
@PBundyra Hi, I think all questions have been addressed. Please have a look if you have time. Thanks very much.
@PBundyra Hi, I think all questions have been addressed. Please have a look if you have time. Thanks very much.
Thank you for addressing my comments. Please add e2e/integration tests as I've mentioned above. You can extend existing e2e tests.
Another thing we're missing here are RBAC roles. See this file for the reference.
Thank you
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@KunWuLuan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kueue-test-e2e-main-1-31 | 8d7f709225bb828c38758a22ccf892f304b1bd0c | link | true | /test pull-kueue-test-e2e-main-1-31 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.