kueue icon indicating copy to clipboard operation
kueue copied to clipboard

MultiKueue JobSet `managed-by`

Open trasc opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add support for JobSet managed-by label.

Which issue(s) this PR fixes:

Fixes #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add MultiKueue support for  JobSet `managed-by` label.

trasc avatar Mar 20 '24 13:03 trasc

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit 901d8ea02038d22e8e7e56c527e3b207432447dc
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/661e7b25e49ce40008f6a612
Deploy Preview https://deploy-preview-1870--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 20 '24 13:03 netlify[bot]

/hold Let's wait for the JobSet 0.5 release which migrates to field, which is tentatively planned for April per https://github.com/kubernetes-sigs/kueue/pull/1870#discussion_r1536007381

mimowo avatar Mar 25 '24 10:03 mimowo

/unhold

trasc avatar Apr 16 '24 07:04 trasc

/lgtm /assign @alculquicondor @tenzen-y Please also adjust the PR description and title to refer to the field.

mimowo avatar Apr 16 '24 10:04 mimowo

LGTM label has been added.

Git tree hash: 5fc7622b2e3abc96d956242b83803c311396cc22

k8s-ci-robot avatar Apr 16 '24 10:04 k8s-ci-robot

/unassign

@mimowo can you handle this one?

alculquicondor avatar Apr 16 '24 12:04 alculquicondor

@mimowo can you handle this one?

I think extra approve will be needed for docs, but I can approve the rest. /approve

mimowo avatar Apr 16 '24 12:04 mimowo

LGTM label has been added.

Git tree hash: f7fb744a7e9a8aee5175e456fa919aba2a27958d

k8s-ci-robot avatar Apr 16 '24 13:04 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mimowo, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 16 '24 13:04 k8s-ci-robot

/release-note-edit

MultiKueue: Add support for  JobSet  `spec.managedBy` field

alculquicondor avatar May 29 '24 20:05 alculquicondor