kueue icon indicating copy to clipboard operation
kueue copied to clipboard

Load shellcheck configuration from the .shellcheckrc

Open alexandear opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add .shelcheckrc to store shellcheck configuration to improve readability and maintainability.

Which issue(s) this PR fixes:

Updates #1518

Special notes for your reviewer:

I'm aware that the Kubernetes project uses the SHELLCHECK_DISABLED variable in hack/verify-shellcheck.sh to ignore issues, rather than using a .shellcheckrc file. This is due to historical reasons: when Kubernetes first introduced shellcheck, it did not support config files.

Does this PR introduce a user-facing change?

NONE

alexandear avatar Mar 14 '24 13:03 alexandear

Hi @alexandear. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 14 '24 13:03 k8s-ci-robot

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit 77e0654a5b5a765f57b5a9ffe2164145786d479c
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/660583bb9433940008c166e9
Deploy Preview https://deploy-preview-1840--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 14 '24 13:03 netlify[bot]

/ok-to-test cc: @Vandit1604

tenzen-y avatar Mar 14 '24 15:03 tenzen-y

@alexandear Could you rebase this PR? Because we added a new make target for the CI.

tenzen-y avatar Mar 28 '24 14:03 tenzen-y

LGTM label has been added.

Git tree hash: cdd517ab3a5e8465e3695cfe8068c31ecf766241

k8s-ci-robot avatar Mar 28 '24 14:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandear, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 28 '24 14:03 k8s-ci-robot