kueue icon indicating copy to clipboard operation
kueue copied to clipboard

[doc] Add steps how to access VisibilityOnDemand via curl

Open xmolitann opened this issue 1 year ago • 8 comments

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Docs are missing a guide on how to access VisibilityOnDemand via curl, omitting kubectl get --raw ..... This is needed if you want to use it programmatically.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

xmolitann avatar Mar 12 '24 12:03 xmolitann

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xmolitann Once this PR has been reviewed and has the lgtm label, please assign moficodes for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 12 '24 12:03 k8s-ci-robot

Welcome @xmolitann!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 12 '24 12:03 k8s-ci-robot

Hi @xmolitann. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 12 '24 12:03 k8s-ci-robot

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit 8289fb95b787b14ef609cfda4312d447e32edf66
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65f048d48b271b00080570f6
Deploy Preview https://deploy-preview-1824--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 12 '24 12:03 netlify[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 26 '24 05:03 k8s-ci-robot

/cc @PBundyra

mimowo avatar May 07 '24 15:05 mimowo

Due to the need of using --insecure flag to avoid using proxy, a user is exposed to MITM attacks which I believe is undesired. Can we find any other alternative or mitigation of this risk?

Docs: https://kubernetes.io/docs/tasks/administer-cluster/access-cluster-api/#without-kubectl-proxy

PBundyra avatar May 09 '24 11:05 PBundyra

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 07 '24 12:08 k8s-triage-robot

@xmolitann would you like / find time to address the comments and complete the review?

mimowo avatar Aug 07 '24 12:08 mimowo

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 06 '24 13:09 k8s-triage-robot

/close

Due to fixed in #3160

mbobrovskyi avatar Oct 03 '24 13:10 mbobrovskyi

@mbobrovskyi: Closed this PR.

In response to this:

/close

Due to fixed in #3160

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 03 '24 13:10 k8s-ci-robot