kueue icon indicating copy to clipboard operation
kueue copied to clipboard

Address all the disabled warnings given by shell check

Open Vandit1604 opened this issue 11 months ago • 12 comments

What would you like to be cleaned: In https://github.com/kubernetes-sigs/kueue/pull/1552, We added shell check to the repository. Currently, we are ignoring a lot of shell check warnings.

# Currently disabled these errors will take care of them later
DISABLED_ERRORS="SC2002,SC3028,SC3054,SC3014,SC3040,SC3046,SC3030,SC3010,SC3037,SC3045,SC3006,SC3018,SC3016,SC3011,SC3044,SC3043,SC3060,SC3024,SC1091,SC2066,SC2086,SC2034,SC1083,SC1009,SC1073,SC1072,SC2155,SC2046"

This issue tracks the progress we make on addressing all the disabled errors/warnings given by shell check. See https://github.com/kubernetes-sigs/kueue/pull/1552 for more information.

Why is this needed: The goals of Shell Check and addressing all the warnings are:

  • To point out and clarify typical beginner's syntax issues that cause a shell to give cryptic error messages.

  • To point out and clarify typical intermediate level semantic problems that cause a shell to behave strangely and counter-intuitively.

  • To point out subtle caveats, corner cases and pitfalls that may cause an advanced user's otherwise working script to fail under future circumstances.

Vandit1604 avatar Mar 04 '24 17:03 Vandit1604

/assign

Vandit1604 avatar Mar 04 '24 17:03 Vandit1604

https://github.com/kubernetes-sigs/kueue/pull/1552#issuecomment-1976589359

Leaving this here so I don't forget this.

Vandit1604 avatar Mar 04 '24 18:03 Vandit1604