kueue icon indicating copy to clipboard operation
kueue copied to clipboard

Switch to the new event recorder in Kueue

Open achernevskii opened this issue 1 year ago • 3 comments

What would you like to be added:

https://github.com/kubernetes-sigs/kueue/issues/1387#issuecomment-1834067535

Switch from record.EventRecorder to events.EventRecorder, which has extra machine-readable fields.

https://github.com/kubernetes/client-go/blob/84a6fe7e4032ae1b8bc03b5208e771c5f7103549/tools/events/interfaces.go#L29

Why is this needed:

It will be useful to distinguish between a "regular" workload finish (when the job ends) versus another kind of failure, in a machine readable way.

Completion requirements:

This enhancement requires the following artifacts:

  • [ ] Design doc
  • [ ] API change
  • [ ] Docs update

The artifacts should be linked in subsequent comments.

achernevskii avatar Dec 18 '23 15:12 achernevskii

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 17 '24 15:03 k8s-triage-robot

/remove-lifecycle stale

tenzen-y avatar Mar 28 '24 18:03 tenzen-y

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 26 '24 19:06 k8s-triage-robot

/remove-lifecycle stale

tenzen-y avatar Jul 08 '24 15:07 tenzen-y

/assign

vladikkuzn avatar Jul 18 '24 14:07 vladikkuzn

It will be useful to distinguish between a "regular" workload finish (when the job ends) versus another kind of failure, in a machine readable way.

It is not clear to me if this motivation is still valid since we have the reason field indicating Failed / Succeeded since https://github.com/kubernetes-sigs/kueue/pull/2026. I would suggest to wait for a proper support of the new interface from the controller-runtime, re-opened the discussion in https://github.com/kubernetes-sigs/controller-runtime/issues/2141.

mimowo avatar Jul 30 '24 13:07 mimowo

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 28 '24 13:10 k8s-triage-robot

/remove-lifecycle stale

tenzen-y avatar Oct 28 '24 15:10 tenzen-y

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 26 '25 16:01 k8s-triage-robot

/lifecycle frozen

tenzen-y avatar Feb 05 '25 13:02 tenzen-y