kueue icon indicating copy to clipboard operation
kueue copied to clipboard

Preemption admission check controller

Open trasc opened this issue 2 years ago • 10 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add the possibility to delay the eviction triggering in case of preemption based on the preempting workload admission checks configuration.

Which issue(s) this PR fixes:

Fixes #1677

Special notes for your reviewer:

Some additional test will be added.

Does this PR introduce a user-facing change?

Manage the eviction on preemption based on admission checks.

trasc avatar Sep 12 '23 14:09 trasc

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Sep 12 '23 14:09 k8s-ci-robot

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit 371072a4272eaf8a2e6e8b59cad319663608c097
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/652785db451b7100086f382e

netlify[bot] avatar Sep 12 '23 14:09 netlify[bot]

/test all

trasc avatar Sep 15 '23 11:09 trasc

/assign

tenzen-y avatar Sep 16 '23 07:09 tenzen-y

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: trasc Once this PR has been reviewed and has the lgtm label, please ask for approval from tenzen-y. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 18 '23 07:09 k8s-ci-robot

/label tide/merge-method-rebase /hold for squash

trasc avatar Sep 29 '23 16:09 trasc

I'd like to take a look at this. I hope to do so by Monday

alculquicondor avatar Sep 29 '23 16:09 alculquicondor

Can you send a PR to update https://github.com/kubernetes-sigs/kueue/tree/main/keps/993-two-phase-admission outlining the approach?

alculquicondor avatar Oct 03 '23 14:10 alculquicondor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 20 '23 23:10 k8s-ci-robot

@trasc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-e2e-main-1-29 371072a4272eaf8a2e6e8b59cad319663608c097 link true /test pull-kueue-test-e2e-main-1-29
pull-kueue-test-multikueue-e2e-main-1-29 371072a4272eaf8a2e6e8b59cad319663608c097 link true /test pull-kueue-test-multikueue-e2e-main-1-29
pull-kueue-test-scheduling-perf-main 371072a4272eaf8a2e6e8b59cad319663608c097 link true /test pull-kueue-test-scheduling-perf-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Apr 18 '24 13:04 k8s-ci-robot

Let's close this for now.

Given all the work we are doing to implement fair sharing preemption, it's not a good time to put this in place.

/close

alculquicondor avatar Apr 18 '24 14:04 alculquicondor

@alculquicondor: Closed this PR.

In response to this:

Let's close this for now.

Given all the work we are doing to implement fair sharing preemption, it's not a good time to put this in place.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 18 '24 14:04 k8s-ci-robot