kueue
kueue copied to clipboard
Preemption admission check controller
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add the possibility to delay the eviction triggering in case of preemption based on the preempting workload admission checks configuration.
Which issue(s) this PR fixes:
Fixes #1677
Special notes for your reviewer:
Some additional test will be added.
Does this PR introduce a user-facing change?
Manage the eviction on preemption based on admission checks.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Deploy Preview for kubernetes-sigs-kueue canceled.
| Name | Link |
|---|---|
| Latest commit | 371072a4272eaf8a2e6e8b59cad319663608c097 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/652785db451b7100086f382e |
/test all
/assign
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: trasc Once this PR has been reviewed and has the lgtm label, please ask for approval from tenzen-y. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/label tide/merge-method-rebase /hold for squash
I'd like to take a look at this. I hope to do so by Monday
Can you send a PR to update https://github.com/kubernetes-sigs/kueue/tree/main/keps/993-two-phase-admission outlining the approach?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@trasc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kueue-test-e2e-main-1-29 | 371072a4272eaf8a2e6e8b59cad319663608c097 | link | true | /test pull-kueue-test-e2e-main-1-29 |
| pull-kueue-test-multikueue-e2e-main-1-29 | 371072a4272eaf8a2e6e8b59cad319663608c097 | link | true | /test pull-kueue-test-multikueue-e2e-main-1-29 |
| pull-kueue-test-scheduling-perf-main | 371072a4272eaf8a2e6e8b59cad319663608c097 | link | true | /test pull-kueue-test-scheduling-perf-main |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Let's close this for now.
Given all the work we are doing to implement fair sharing preemption, it's not a good time to put this in place.
/close
@alculquicondor: Closed this PR.
In response to this:
Let's close this for now.
Given all the work we are doing to implement fair sharing preemption, it's not a good time to put this in place.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.