kubetest2 icon indicating copy to clipboard operation
kubetest2 copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Add support for an extra nodepool.

Open hoskeri opened this issue 2 years ago • 7 comments

Add support for extra nodepool when creating the test cluster.

hoskeri avatar Jun 16 '22 22:06 hoskeri

Welcome @hoskeri!

It looks like this is your first PR to kubernetes-sigs/kubetest2 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubetest2 has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jun 16 '22 22:06 k8s-ci-robot

Hi @hoskeri. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 16 '22 22:06 k8s-ci-robot

/ok-to-test

chizhg avatar Jun 17 '22 18:06 chizhg

/lgtm

liggitt avatar Oct 11 '22 17:10 liggitt

/lgtm

liggitt avatar Oct 11 '22 22:10 liggitt

/assign @mushuee

hoskeri avatar Oct 11 '22 22:10 hoskeri

/lgtm /approved

MushuEE avatar Oct 18 '22 23:10 MushuEE

/approve

MushuEE avatar Oct 19 '22 02:10 MushuEE

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hoskeri, MushuEE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 19 '22 02:10 k8s-ci-robot